Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/mb/mb_config.pyl

Issue 1942563002: gn: add is_ubsan_no_recover to halt the program on the first problem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Half->Halt Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/sanitizers/sanitizers.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb_config.pyl
diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
index e7b66df0a4b62f52d79878b4d51505fb371e3966..c2f9291b5070d598e80970ddd696f191d89e5176 100644
--- a/tools/mb/mb_config.pyl
+++ b/tools/mb/mb_config.pyl
@@ -1157,7 +1157,7 @@
],
'gn_ubsan_vptr_release_bot': [
- 'gn', 'ubsan_vptr', 'release_bot',
+ 'gn', 'ubsan_vptr', 'ubsan_no_recover_hack', 'release_bot',
],
'gyp_asan_lsan_edge_fuzzer_debug_bot': [
@@ -2307,7 +2307,7 @@
# TODO(krasin): Remove when https://llvm.org/bugs/show_bug.cgi?id=25569
# is fixed and just use ubsan_vptr instead.
'mixins': ['ubsan_vptr'],
- 'gn_args': 'error', # TODO(GYP): need a GN equivalent for this
+ 'gn_args': 'is_ubsan_no_recover=true',
'gyp_defines': 'release_extra_cflags=-fno-sanitize-recover=undefined',
},
« no previous file with comments | « build/config/sanitizers/sanitizers.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698