Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1942513002: Adding default_exe_manifest to one binary (Closed)

Created:
4 years, 7 months ago by brucedawson
Modified:
4 years, 7 months ago
Reviewers:
scheib
CC:
chromium-reviews, darin-cc_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding default_exe_manifest to one binary gn builds are missing Windows manifests for bluetooth_metrics_hash.exe. This manifest is necessary in order to get predictable behavior on Windows. BUG=602505 Committed: https://crrev.com/bc9b39fc8203807b649b3b773f786bf2c8628f0f Cr-Commit-Position: refs/heads/master@{#391179}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/bluetooth/tools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
Can you take a look? This is one of a set of CLs to get ...
4 years, 7 months ago (2016-04-30 00:03:23 UTC) #2
scheib
LGTM
4 years, 7 months ago (2016-05-02 23:17:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942513002/1
4 years, 7 months ago (2016-05-03 04:03:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 06:20:34 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 06:21:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc9b39fc8203807b649b3b773f786bf2c8628f0f
Cr-Commit-Position: refs/heads/master@{#391179}

Powered by Google App Engine
This is Rietveld 408576698