Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1925493002: Add manifests to many more gn built exe files (Closed)

Created:
4 years, 8 months ago by brucedawson
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, sadrul, zea+watch_chromium.org, chromoting-reviews_chromium.org, johnme+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, samuong+watch_chromium.org, jam, darin-cc_chromium.org, sync-reviews_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, mlamouri+watch-content_chromium.org, kalyank, imcheng+watch_chromium.org, Peter Beverloo, jasonroberts+watch_google.com, feature-media-reviews_chromium.org, caitkp+watch_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, Dirk Pranke, mlamouri+watch-test-runner_chromium.org, wfh+watch_chromium.org, avayvod+watch_chromium.org, telemetry-reviews_chromium.org, tfarina, isheriff+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add manifests to many more gn built exe files About 80 exe files were still missing manifests when doing gn builds (as tested with a debug gn 64-bit build with no target specified, if that matters) and this adds manifests for all except two pdfium binaries. Because the manifests include OS compatibility information it is important to have them in order to prevent Windows from doing bizarre backwards compatibility hacks. BUG=602505 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/f9f7d629721ad9c14b1053e373436f2f3292f92d Cr-Commit-Position: refs/heads/master@{#390145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -0 lines) Patch
M ash/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/chromedriver/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/convert_dict/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_elf/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/wifi/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M courgette/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gin/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gles2_conform_support/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/BUILD.gn View 6 chunks +6 lines, -0 lines 0 comments Download
M net/BUILD.gn View 16 chunks +16 lines, -0 lines 0 comments Download
M ppapi/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M remoting/test/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M rlz/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/shell/runner/child/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/shell/standalone/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/shell/tests/connect/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M services/shell/tests/lifecycle/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/shell/tests/shell/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M storage/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sync/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/codesighs/BUILD.gn View 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/opus/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/qcms/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/battor_agent/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/imagediff/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/clear_system_cache/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M win8/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
brucedawson
World's most boring CL. All it does is add 72 occurrences of the same line. ...
4 years, 8 months ago (2016-04-27 00:37:30 UTC) #3
brettw
lgtm
4 years, 7 months ago (2016-04-27 05:16:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925493002/1
4 years, 7 months ago (2016-04-27 16:53:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 19:11:25 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:11:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9f7d629721ad9c14b1053e373436f2f3292f92d
Cr-Commit-Position: refs/heads/master@{#390145}

Powered by Google App Engine
This is Rietveld 408576698