Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1942383002: Enable hermetic builds for FYI mac builders. (Closed)

Created:
4 years, 7 months ago by justincohen
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Enable hermetic builds for FYI mac builders. BUG=474373 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300441

Patch Set 1 #

Total comments: 4

Patch Set 2 : Revert chromium_mac changes, and run train script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -323 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 14 chunks +27 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_10_MacViews.json View 1 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11.json View 1 3 chunks +3 lines, -0 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11_Force_Mac_Toolchain.json View 1 1 chunk +0 lines, -297 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary.json View 1 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__clobber_.json View 1 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__dbg_.json View 1 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__dbg__clobber_.json View 1 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac.json View 1 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json View 1 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan_tester.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac__dbg_.json View 1 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac_tester.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mac_OpenSSL.json View 1 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Print_Preview_Mac.json View 1 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_10_macviews.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
justincohen
Is this the right way to do this? Am I covering all the right machines? ...
4 years, 7 months ago (2016-05-03 16:44:52 UTC) #3
erikchen
https://codereview.chromium.org/1942383002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right): https://codereview.chromium.org/1942383002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py#newcode49 scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:49: 'force_mac_toolchain' You probably need to run """ ./scripts/slave/unittests/recipe_simulation_test.py train ...
4 years, 7 months ago (2016-05-03 16:48:57 UTC) #4
justincohen
ptal https://codereview.chromium.org/1942383002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right): https://codereview.chromium.org/1942383002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py#newcode49 scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:49: 'force_mac_toolchain' On 2016/05/03 16:48:57, erikchen wrote: > You ...
4 years, 7 months ago (2016-05-03 17:32:58 UTC) #5
smut
lgtm
4 years, 7 months ago (2016-05-03 21:29:00 UTC) #6
erikchen
lgtm
4 years, 7 months ago (2016-05-03 21:48:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942383002/20001
4 years, 7 months ago (2016-05-04 13:55:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/4625)
4 years, 7 months ago (2016-05-04 14:03:00 UTC) #12
justincohen
Over to dpranke@ or phajdan.jr@ for OWNERS, whoever gets to it first!
4 years, 7 months ago (2016-05-04 14:22:17 UTC) #14
Paweł Hajdan Jr.
LGTM
4 years, 7 months ago (2016-05-04 15:50:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942383002/20001
4 years, 7 months ago (2016-05-04 15:52:08 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300441
4 years, 7 months ago (2016-05-04 15:56:30 UTC) #19
erikchen
lgtm
4 years, 7 months ago (2016-05-04 16:10:55 UTC) #20
justincohen
4 years, 7 months ago (2016-05-04 22:45:06 UTC) #21
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1946023004/ by justincohen@chromium.org.

The reason for reverting is: This broke a bunch of FYI bots..

Powered by Google App Engine
This is Rietveld 408576698