scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11.json - Issue 1942383002: Enable hermetic builds for FYI mac builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11.json

Issue 1942383002: Enable hermetic builds for FYI mac builders. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Revert chromium_mac changes, and run train script Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_10_MacViews.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11_Force_Mac_Toolchain.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11.json b/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11.json

index 7d9697443d9a9354a933b736a37959a25def56d7..d139b6b77f5ec6c7bddf8de48aa7837c7bab3170 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11.json

@@ -166,6 +166,7 @@

"runhooks"

"env": {

+ "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

"GYP_CHROMIUM_NO_ACTION": "1",

"GYP_DEFINES": "clang=1 component=static_library gomadir='[CACHE]/cipd/goma' target_arch=x64 use_goma=1",

@@ -253,6 +254,7 @@

"/path/to/tmp/json"

"env": {

+ "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

"name": "clang_revision",

@@ -300,6 +302,7 @@

"chromium_builder_tests"

"env": {

+ "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

"name": "compile",