Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1942073002: [DevTools] Move getCompletions to native (Closed)

Created:
4 years, 7 months ago by kozy
Modified:
4 years, 7 months ago
Reviewers:
lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move getCompletions to native - introduce Runtime.getCompletions hidden protocol method, - support completions for proxy, - better guaranties that request for completions doesn't run any JS. BUG=581495 R=lushnikov@chromium.org,pfeldman@chromium.org

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -58 lines) Patch
A third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-getCompletions.html View 1 1 chunk +78 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-getCompletions-expected.txt View 1 1 chunk +80 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js View 2 chunks +29 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 1 3 chunks +8 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 1 1 chunk +85 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kozy
Andrey and Pavel, please take a look!
4 years, 7 months ago (2016-05-03 02:09:41 UTC) #2
pfeldman
https://codereview.chromium.org/1942073002/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js File third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js (right): https://codereview.chromium.org/1942073002/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js#newcode264 third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:264: getCompletionsPromise: function() completionsPromise https://codereview.chromium.org/1942073002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right): https://codereview.chromium.org/1942073002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp#newcode150 third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:150: ...
4 years, 7 months ago (2016-05-03 18:07:25 UTC) #3
kozy
4 years, 7 months ago (2016-05-04 01:48:31 UTC) #4
Message was sent while issue was closed. 
Implemented on frontend side.

Powered by Google App Engine
This is Rietveld 408576698