third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h - Issue 1942073002: [DevTools] Move getCompletions to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 1942073002: [DevTools] Move getCompletions to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

index caad78d6eb27b8b297ab5fdd21ab2cf1335b8c47..fa9653e96eb4c3e54ae1cac683a55ae4e37c8a66 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

@@ -95,6 +95,10 @@ public:

OwnPtr<protocol::Array<protocol::Runtime::PropertyDescriptor>>* result,

Maybe<protocol::Array<protocol::Runtime::InternalPropertyDescriptor>>* internalProperties,

Maybe<protocol::Runtime::ExceptionDetails>*) override;

+ void getCompletions(ErrorString*,

+ const Maybe<String16>& objectId,

+ const Maybe<String16>& primitiveType,

+ OwnPtr<protocol::Array<String16>>*);

void releaseObjectGroup(ErrorString*, const String16& objectGroup) override;

void run(ErrorString*) override;

void setCustomObjectFormatterEnabled(ErrorString*, bool) override;