Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 1942033002: Fix DocWriteEvaluator bg paint metrics (Closed)

Created:
4 years, 7 months ago by Charlie Harrison
Modified:
4 years, 7 months ago
Reviewers:
Bryan McQuade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DocWriteEvaluator bg paint metrics Some background histograms were logging page loads that never painted as 0-ms paints. BUG=608709 Committed: https://crrev.com/6e99bfdeeae1c67b539898d0cbade15708c3be7e Cr-Commit-Position: refs/heads/master@{#391251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Charlie Harrison
PTAL. Not a super high priority metric but it should be fixed.
4 years, 7 months ago (2016-05-03 13:40:39 UTC) #3
Bryan McQuade
lgtm
4 years, 7 months ago (2016-05-03 13:58:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942033002/1
4 years, 7 months ago (2016-05-03 15:44:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 16:18:42 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 16:19:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e99bfdeeae1c67b539898d0cbade15708c3be7e
Cr-Commit-Position: refs/heads/master@{#391251}

Powered by Google App Engine
This is Rietveld 408576698