Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4439)

Unified Diff: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

Issue 1942033002: Fix DocWriteEvaluator bg paint metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
index a26c8bad2a62f972d48d0c19460bb9ee02090aec..87cd9e5dac4e5fc2663bce3acfd1af8d951fed42 100644
--- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
@@ -61,13 +61,15 @@ void DocumentWritePageLoadMetricsObserver::LogDocumentWriteEvaluatorData(
const page_load_metrics::PageLoadExtraInfo& info) {
bool foreground_paint = WasStartedInForegroundEventInForeground(
timing.first_contentful_paint, info);
- if (foreground_paint) {
- PAGE_LOAD_HISTOGRAM(internal::kHistogramDocWriteFirstContentfulPaint,
- timing.first_contentful_paint);
- } else {
- PAGE_LOAD_HISTOGRAM(
- internal::kBackgroundHistogramDocWriteFirstContentfulPaint,
- timing.first_contentful_paint);
+ if (!timing.first_contentful_paint.is_zero()) {
+ if (foreground_paint) {
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramDocWriteFirstContentfulPaint,
+ timing.first_contentful_paint);
+ } else {
+ PAGE_LOAD_HISTOGRAM(
+ internal::kBackgroundHistogramDocWriteFirstContentfulPaint,
+ timing.first_contentful_paint);
+ }
}
// Log parse based metrics.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698