Fix geolocation removal from insecure contexts console message

Fix geolocation removal from insecure contexts console message

The console message when the geolocation API is used in insecure
messages ambiguously says it is deprecated when, in fact, it has been
removed at this point. This updates the message to match getUserMedia()
and say it is removed.

BUG=605938
R=rbyers@chromium.org

Committed: https://crrev.com/f08d3200d37b28a9de02d28f7396e99966827551
Cr-Commit-Position: refs/heads/master@{#392126}

[jww, 2016-05-02 21:42:03]

Rick, can you take a look?

[jww, 2016-05-02 21:42:15]

The CQ bit was checked by jww@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-02 21:42:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942003002/1

[Rick Byers, 2016-05-02 21:43:40]

https://codereview.chromium.org/1942003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/1942003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:297: // should be updated
to read similarly to GetUserMediaInsecureOrigin's
Is this TODO still relevant?  I.e. does geolocation actually still work in
WebView?  Can you make it dynamic (or worst case use an #ifdef) for the WebView
case?

[jww, 2016-05-02 21:59:12]

https://codereview.chromium.org/1942003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/1942003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:297: // should be updated
to read similarly to GetUserMediaInsecureOrigin's
On 2016/05/02 21:43:40, Rick Byers wrote:
> Is this TODO still relevant?  I.e. does geolocation actually still work in
> WebView?  Can you make it dynamic (or worst case use an #ifdef) for the
WebView
> case?

Arg, I totally blanked on that case, and that's why I made the messaging
ambiguous in the first place. Yay for putting in comments that explain things!

Yes, it is still relevant. It's a bit messy because this is defined by a
setting, which we can only get via a Frame, and we don't have one at this point.
I'll brainstorm a solution because, you're right, this message should remain for
WebViews. My immediate thought is to just add a second UseCounter for
GeolocationDeprecatedNotRemovedYet, which seems like a useful counter to have
anyway.

[commit-bot: I haz the power, 2016-05-02 23:53:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-02 23:53:01]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jww, 2016-05-03 00:34:29]

Rick, how do you feel about this approach?

[Rick Byers, 2016-05-04 13:57:07]

Yeah, counting the two cases separately makes sense.  Thanks.  LGTM with nit.

https://codereview.chromium.org/1942003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/geolocation/Geolocation.cpp (right):

https://codereview.chromium.org/1942003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/geolocation/Geolocation.cpp:159: // TODO(jww):
This should be removed after WebView is fixed so that it
nit: have a bug number to reference?

[jww, 2016-05-05 19:17:41]

jww@chromium.org changed reviewers:
+ asvitkine@chromium.org, mvanouwerkerk@chromium.org

[jww, 2016-05-05 19:17:42]

mvanouwerkerk@chromium.org: Can you take a look at the geolocation.cpp changes?

asvitkine@, can you look at the histogram.xml changes?

https://codereview.chromium.org/1942003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/geolocation/Geolocation.cpp (right):

https://codereview.chromium.org/1942003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/geolocation/Geolocation.cpp:159: // TODO(jww):
This should be removed after WebView is fixed so that it
On 2016/05/04 13:57:07, Rick Byers wrote:
> nit: have a bug number to reference?

Done.

[Alexei Svitkine (slow), 2016-05-05 19:27:48]

lgtm

[Michael van Ouwerkerk, 2016-05-06 17:24:20]

lgtm

[jww, 2016-05-06 17:31:49]

The CQ bit was checked by jww@chromium.org

[jww, 2016-05-06 17:31:49]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org,
asvitkine@chromium.org, mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/1942003002/#ps100001
(title: "Rebase on ToT")

[commit-bot: I haz the power, 2016-05-06 17:32:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942003002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942003002/100001

[commit-bot: I haz the power, 2016-05-06 19:36:34]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-06 19:38:09]

Description was changed from

==========
Fix geolocation removal from insecure contexts console message

The console message when the geolocation API is used in insecure
messages ambiguously says it is deprecated when, in fact, it has been
removed at this point. This updates the message to match getUserMedia()
and say it is removed.

BUG=605938
R=rbyers@chromium.org
==========

to

==========
Fix geolocation removal from insecure contexts console message

The console message when the geolocation API is used in insecure
messages ambiguously says it is deprecated when, in fact, it has been
removed at this point. This updates the message to match getUserMedia()
and say it is removed.

BUG=605938
R=rbyers@chromium.org

Committed: https://crrev.com/f08d3200d37b28a9de02d28f7396e99966827551
Cr-Commit-Position: refs/heads/master@{#392126}
==========

[commit-bot: I haz the power, 2016-05-06 19:38:11]

Patchset 6 (id:??) landed as
https://crrev.com/f08d3200d37b28a9de02d28f7396e99966827551
Cr-Commit-Position: refs/heads/master@{#392126}