Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1942003002: Fix geolocation removal from insecure contexts console message (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Rebase on ToT Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/Deprecation.h" 5 #include "core/frame/Deprecation.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/FrameConsole.h" 9 #include "core/frame/FrameConsole.h"
10 #include "core/frame/FrameHost.h" 10 #include "core/frame/FrameHost.h"
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 return "The devicemotion event is deprecated on insecure origins, and su pport will be removed in the future. You should consider switching your applicat ion to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more detail s."; 285 return "The devicemotion event is deprecated on insecure origins, and su pport will be removed in the future. You should consider switching your applicat ion to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more detail s.";
286 286
287 case UseCounter::DeviceOrientationInsecureOrigin: 287 case UseCounter::DeviceOrientationInsecureOrigin:
288 return "The deviceorientation event is deprecated on insecure origins, a nd support will be removed in the future. You should consider switching your app lication to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more d etails."; 288 return "The deviceorientation event is deprecated on insecure origins, a nd support will be removed in the future. You should consider switching your app lication to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more d etails.";
289 289
290 case UseCounter::DeviceOrientationAbsoluteInsecureOrigin: 290 case UseCounter::DeviceOrientationAbsoluteInsecureOrigin:
291 return "The deviceorientationabsolute event is deprecated on insecure or igins, and support will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz fo r more details."; 291 return "The deviceorientationabsolute event is deprecated on insecure or igins, and support will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz fo r more details.";
292 292
293 case UseCounter::GeolocationInsecureOrigin: 293 case UseCounter::GeolocationInsecureOrigin:
294 case UseCounter::GeolocationInsecureOriginIframe: 294 case UseCounter::GeolocationInsecureOriginIframe:
295 // TODO(jww): This message should be made less ambigous after WebView 295 return "getCurrentPosition() and watchPosition() no longer work on insec ure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details." ;
296 // is fixed so geolocation can be removed there. After that, this 296
297 // should be updated to read similarly to GetUserMediaInsecureOrigin's 297 case UseCounter::GeolocationInsecureOriginDeprecatedNotRemoved:
298 // message. 298 case UseCounter::GeolocationInsecureOriginIframeDeprecatedNotRemoved:
299 return "getCurrentPosition() and watchPosition() are deprecated on insec ure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details." ; 299 return "getCurrentPosition() and watchPosition() are deprecated on insec ure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details." ;
300 300
301 case UseCounter::GetUserMediaInsecureOrigin: 301 case UseCounter::GetUserMediaInsecureOrigin:
302 case UseCounter::GetUserMediaInsecureOriginIframe: 302 case UseCounter::GetUserMediaInsecureOriginIframe:
303 return "getUserMedia() no longer works on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details."; 303 return "getUserMedia() no longer works on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";
304 304
305 case UseCounter::EncryptedMediaInsecureOrigin: 305 case UseCounter::EncryptedMediaInsecureOrigin:
306 return "requestMediaKeySystemAccess() is deprecated on insecure origins in the specification. Support will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.g l/rStTGz for more details."; 306 return "requestMediaKeySystemAccess() is deprecated on insecure origins in the specification. Support will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.g l/rStTGz for more details.";
307 307
308 case UseCounter::ApplicationCacheManifestSelectInsecureOrigin: 308 case UseCounter::ApplicationCacheManifestSelectInsecureOrigin:
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 case UseCounter::URLMethodRevokeObjectURLServiceWorker: 394 case UseCounter::URLMethodRevokeObjectURLServiceWorker:
395 return willBeRemoved("The 'URL.revokeObjectURL' method in Service Worker s", 52, "5685092332601344"); 395 return willBeRemoved("The 'URL.revokeObjectURL' method in Service Worker s", 52, "5685092332601344");
396 396
397 // Features that aren't deprecated don't have a deprecation message. 397 // Features that aren't deprecated don't have a deprecation message.
398 default: 398 default:
399 return String(); 399 return String();
400 } 400 }
401 } 401 }
402 402
403 } // namespace blink 403 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698