Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1941943002: [Mac] Replace find_{next,prev}_Template.pdf with vector icons. (Closed)

Created:
4 years, 7 months ago by Robert Sesek
Modified:
4 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Replace find_{next,prev}_Template.pdf with vector icons. BUG=111101 R=thakis@chromium.org Committed: https://crrev.com/26f09f1486d804294972803470b8a66f47c1a084 Cr-Commit-Position: refs/heads/master@{#391059}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M chrome/app/nibs/FindBar.xib View 3 chunks +2 lines, -6 lines 0 comments Download
D chrome/app/theme/find_next_Template.pdf View Binary file 0 comments Download
D chrome/app/theme/find_prev_Template.pdf View Binary file 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 2 chunks +14 lines, -0 lines 1 comment Download
M chrome/chrome_dll_bundle.gypi View 2 chunks +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Robert Sesek
4 years, 7 months ago (2016-05-02 20:24:32 UTC) #3
Nico
lgtm https://codereview.chromium.org/1941943002/diff/1/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm File chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm (right): https://codereview.chromium.org/1941943002/diff/1/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm#newcode138 chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm:138: gfx::CreateVectorIcon(gfx::VectorIconId::FIND_NEXT, SK_ColorBLACK)); TIL
4 years, 7 months ago (2016-05-02 21:28:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941943002/1
4 years, 7 months ago (2016-05-02 21:41:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 21:45:33 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 21:46:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26f09f1486d804294972803470b8a66f47c1a084
Cr-Commit-Position: refs/heads/master@{#391059}

Powered by Google App Engine
This is Rietveld 408576698