Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1938893003: [Mac] Remove pdfsqueeze. (Closed)

Created:
4 years, 7 months ago by Robert Sesek
Modified:
4 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@mac-pdfs-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Remove pdfsqueeze. BUG=111101, 542415, 46227, 328558, 39240 R=thakis@chromium.org Committed: https://crrev.com/13c5f9add30e4c647959ab100b579c7f21c8e5f3 Cr-Commit-Position: refs/heads/master@{#391093}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -70 lines) Patch
M DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D build/temp_gyp/README.chromium View 1 chunk +0 lines, -3 lines 3 comments Download
D build/temp_gyp/pdfsqueeze.gyp View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 2 chunks +0 lines, -17 lines 0 comments Download
M tools/licenses.py View 2 chunks +0 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
Robert Sesek
https://codereview.chromium.org/1938893003/diff/1/build/temp_gyp/README.chromium File build/temp_gyp/README.chromium (left): https://codereview.chromium.org/1938893003/diff/1/build/temp_gyp/README.chromium#oldcode1 build/temp_gyp/README.chromium:1: This directory will be removed once the files in ...
4 years, 7 months ago (2016-05-02 20:32:00 UTC) #1
Nico
lgtm, nice! Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=46227 too. And now that I'm looking for it, also https://bugs.chromium.org/p/chromium/issues/detail?id=328558 and ...
4 years, 7 months ago (2016-05-02 21:32:30 UTC) #2
Robert Sesek
On 2016/05/02 21:32:30, Nico wrote: > Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=46227 too. And now > that I'm looking ...
4 years, 7 months ago (2016-05-02 21:49:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938893003/1
4 years, 7 months ago (2016-05-02 22:14:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 23:30:44 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 23:32:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13c5f9add30e4c647959ab100b579c7f21c8e5f3
Cr-Commit-Position: refs/heads/master@{#391093}

Powered by Google App Engine
This is Rietveld 408576698