Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1941783004: Fix seeking after redirect (Closed)

Created:
4 years, 7 months ago by hubbe
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix seeking after redirect The data length was behing applied to the old UrlData instance instead of the new one after a redirect. Not knowing the length disables seeking, this CL fixes that and adds a test to prevent the problem from occuring again. BUG=606965 Review-Url: https://codereview.chromium.org/1932823002 Cr-Commit-Position: refs/heads/master@{#390498} (cherry picked from commit 1fed486149cdfb7ad37fe474e3ab78d62cab42db) Committed: https://chromium.googlesource.com/chromium/src/+/6ba2ce7dcaf9ed453405c542dadec634810e47c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M media/blink/multibuffer_data_source_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M media/blink/resource_multibuffer_data_provider.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/blink/resource_multibuffer_data_provider.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hubbe
4 years, 7 months ago (2016-05-02 22:57:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ba2ce7dcaf9ed453405c542dadec634810e47c5 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698