Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1932823002: Fix seeking after redirect (Closed)

Created:
4 years, 7 months ago by hubbe
Modified:
4 years, 7 months ago
Reviewers:
watk
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix seeking after redirect The data length was behing applied to the old UrlData instance instead of the new one after a redirect. Not knowing the length disables seeking, this CL fixes that and adds a test to prevent the problem from occuring again. BUG=606965 Committed: https://crrev.com/1fed486149cdfb7ad37fe474e3ab78d62cab42db Cr-Commit-Position: refs/heads/master@{#390498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M media/blink/multibuffer_data_source_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M media/blink/resource_multibuffer_data_provider.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/blink/resource_multibuffer_data_provider.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hubbe
4 years, 7 months ago (2016-04-28 18:52:54 UTC) #2
watk
lgtm
4 years, 7 months ago (2016-04-28 18:57:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932823002/1
4 years, 7 months ago (2016-04-28 19:10:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 21:59:03 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:21:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fed486149cdfb7ad37fe474e3ab78d62cab42db
Cr-Commit-Position: refs/heads/master@{#390498}

Powered by Google App Engine
This is Rietveld 408576698