Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 194173002: Undeprecate Event.returnValue and Attr.specified (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Undeprecate Event.returnValue and Attr.specified The usage of these is so high that complaining about them is likely to make developers ignore console warnings: http://www.chromestatus.com/metrics/feature/timeline/popularity/137 http://www.chromestatus.com/metrics/feature/timeline/popularity/162 Spec bugs filed to maybe make them standard instead: https://www.w3.org/Bugs/Public/show_bug.cgi?id=25001 https://www.w3.org/Bugs/Public/show_bug.cgi?id=25002 Discussion on blink-dev: https://groups.google.com/a/chromium.org/d/msg/blink-dev/eplNSf8oDfw/0kB2gD0lQHgJ BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168918

Patch Set 1 #

Patch Set 2 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M LayoutTests/dom/html/level1/core/hc_attrspecifiedvalue-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrspecifiedvaluechanged-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_elementassociatedattribute-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_namednodemapreturnattrnode-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrspecifiedvalue-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrspecifiedvaluechanged-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_elementassociatedattribute-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_namednodemapreturnattrnode-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode02-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode03-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode04-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode05-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/console/console-format-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/jquery/attributes-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/jquery/event-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Attr.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/Event.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
philipj_slow
6 years, 9 months ago (2014-03-11 04:12:01 UTC) #1
eseidel
lgtm Thank you very much for follwing up here.
6 years, 9 months ago (2014-03-11 04:25:59 UTC) #2
eseidel
It looks like there is still some discussion around Event.returnValue. Anecdotally, I see the Event.returnValue ...
6 years, 9 months ago (2014-03-11 04:32:19 UTC) #3
philipj_slow
Discussion is at https://www.w3.org/Bugs/Public/show_bug.cgi?id=25002 Nevertheless, removing Event.returnValue is going to require some other counter than ...
6 years, 9 months ago (2014-03-11 07:03:12 UTC) #4
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-11 07:05:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/194173002/1
6 years, 9 months ago (2014-03-11 07:05:03 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 07:38:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-11 07:38:40 UTC) #8
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-11 09:07:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/194173002/20001
6 years, 9 months ago (2014-03-11 09:07:46 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 10:19:32 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-11 10:19:33 UTC) #12
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-11 10:43:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/194173002/20001
6 years, 9 months ago (2014-03-11 10:43:24 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 10:48:11 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-11 10:48:12 UTC) #16
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-11 11:32:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/194173002/20001
6 years, 9 months ago (2014-03-11 11:32:26 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 12:42:38 UTC) #19
Message was sent while issue was closed. 
Change committed as 168918

Powered by Google App Engine
This is Rietveld 408576698