Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 194173002: Undeprecate Event.returnValue and Attr.specified (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: update test expectations Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/events/Event.idl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 628 matching lines...) Expand 10 before | Expand all | Expand 10 after
639 639
640 case ReleaseEvents: 640 case ReleaseEvents:
641 return "releaseEvents() is deprecated. This method doesn't do anything." ; 641 return "releaseEvents() is deprecated. This method doesn't do anything." ;
642 642
643 case ConsoleMarkTimeline: 643 case ConsoleMarkTimeline:
644 return "console.markTimeline is deprecated. Please use the console.timeS tamp instead."; 644 return "console.markTimeline is deprecated. Please use the console.timeS tamp instead.";
645 645
646 case FileError: 646 case FileError:
647 return "FileError is deprecated. Please use the 'name' or 'message' attr ibutes of DOMError rather than 'code'."; 647 return "FileError is deprecated. Please use the 'name' or 'message' attr ibutes of DOMError rather than 'code'.";
648 648
649 case EventReturnValue:
650 return "event.returnValue is deprecated. Please use the standard event.p reventDefault() instead.";
651
652 case ShowModalDialog: 649 case ShowModalDialog:
653 return "Chromium is considering deprecating showModalDialog. Please use window.open and postMessage instead."; 650 return "Chromium is considering deprecating showModalDialog. Please use window.open and postMessage instead.";
654 651
655 case CSSStyleSheetInsertRuleOptionalArg: 652 case CSSStyleSheetInsertRuleOptionalArg:
656 return "Calling CSSStyleSheet.insertRule() with one argument is deprecat ed. Please pass the index argument as well: insertRule(x, 0)."; 653 return "Calling CSSStyleSheet.insertRule() with one argument is deprecat ed. Please pass the index argument as well: insertRule(x, 0).";
657 654
658 case AttributeSpecified:
659 return "Attr.specified is deprecated. Its value is always true.";
660
661 case SVGElementGetPresentationAttribute: 655 case SVGElementGetPresentationAttribute:
662 return "CSSValue and SVGElement.getPresentationAttribute are deprecated. Please use getPropertyValue and parse the return value instead."; 656 return "CSSValue and SVGElement.getPresentationAttribute are deprecated. Please use getPropertyValue and parse the return value instead.";
663 657
664 case PrefixedMediaSourceOpen: 658 case PrefixedMediaSourceOpen:
665 return "'WebKitMediaSource' is deprecated. Please use 'MediaSource' inst ead."; 659 return "'WebKitMediaSource' is deprecated. Please use 'MediaSource' inst ead.";
666 660
667 case DOMImplementationCreateCSSStyleSheet: 661 case DOMImplementationCreateCSSStyleSheet:
668 return "'DOMImplementation.createCSSStyleSheet()' is deprecated."; 662 return "'DOMImplementation.createCSSStyleSheet()' is deprecated.";
669 663
670 case MediaErrorEncrypted: 664 case MediaErrorEncrypted:
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
726 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 720 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
727 { 721 {
728 // FIXME: We may want to handle stylesheets that have multiple owners 722 // FIXME: We may want to handle stylesheets that have multiple owners
729 // http://crbug.com/242125 723 // http://crbug.com/242125
730 if (sheetContents && sheetContents->hasSingleOwnerNode()) 724 if (sheetContents && sheetContents->hasSingleOwnerNode())
731 return getFrom(sheetContents->singleOwnerDocument()); 725 return getFrom(sheetContents->singleOwnerDocument());
732 return 0; 726 return 0;
733 } 727 }
734 728
735 } // namespace WebCore 729 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/events/Event.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698