Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1941693002: Weak HTMLMediaElement::m_audioSourceNode reference must be cleared. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Weak HTMLMediaElement::m_audioSourceNode reference must be cleared. Weak callbacks must clear the weak references deemed not to be alive. R= BUG= Committed: https://crrev.com/070d27bad29a379739528b93169d1965d649057c Cr-Commit-Position: refs/heads/master@{#390910}

Patch Set 1 #

Patch Set 2 : clear the weak reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
sof
please take a look. (see ps#1 flaky failures for cases where this happens.)
4 years, 7 months ago (2016-05-02 07:52:50 UTC) #2
haraken
Well spotted... LGTM.
4 years, 7 months ago (2016-05-02 08:06:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941693002/20001
4 years, 7 months ago (2016-05-02 08:22:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/206835)
4 years, 7 months ago (2016-05-02 08:51:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941693002/20001
4 years, 7 months ago (2016-05-02 09:49:32 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 10:37:48 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 10:39:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/070d27bad29a379739528b93169d1965d649057c
Cr-Commit-Position: refs/heads/master@{#390910}

Powered by Google App Engine
This is Rietveld 408576698