Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1941693002: Weak HTMLMediaElement::m_audioSourceNode reference must be cleared. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clear the weak reference Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 0957206f03f80460381ac266a4bf48e5aee94d3a..8beea08cbcdda8e7b55f8d57890f68315abf9bed 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -3751,8 +3751,10 @@ void HTMLMediaElement::rejectPlayPromises(ExceptionCode code, const String& mess
void HTMLMediaElement::clearWeakMembers(Visitor* visitor)
{
- if (!ThreadHeap::isHeapObjectAlive(m_audioSourceNode))
+ if (!ThreadHeap::isHeapObjectAlive(m_audioSourceNode)) {
getAudioSourceProvider().setClient(nullptr);
+ m_audioSourceNode = nullptr;
+ }
}
void HTMLMediaElement::AudioSourceProviderImpl::wrap(WebAudioSourceProvider* provider)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698