Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1941673002: [turbofan] Remove left-over change bits from ChangeLowering. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove left-over change bits from ChangeLowering. Now ChangeLowering is only concerned with lowering memory access and allocation operations, and all changes are consistently lowered during the effect/control linearization pass. The next step is to move the left over lowerings to a pass dedicated to eliminate redundant loads and stores, eliminate write barriers, fold and inline allocations. Drive-by-fix: Rename ChangeBitToBool to ChangeBitToTagged, ChangeBoolToBit to ChangeTaggedToBit, and ChangeInt31ToTagged to ChangeInt31ToTaggedSigned for consistency. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel Committed: https://crrev.com/ceca5ae308bddda166651c654f96d71d74f617d0 Cr-Commit-Position: refs/heads/master@{#35924} Committed: https://crrev.com/4aa02441dadec2b1cf60f69ba5c30a4a89df576b Cr-Commit-Position: refs/heads/master@{#35929}

Patch Set 1 #

Patch Set 2 : Also remove the atomic regions after effect/control linearization #

Patch Set 3 : Don't mess with the regions yet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -377 lines) Patch
M src/compiler/change-lowering.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/compiler/change-lowering.cc View 5 chunks +1 line, -67 lines 0 comments Download
M src/compiler/effect-control-linearizer.h View 3 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 15 chunks +99 lines, -16 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/representation-change.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M src/compiler/verifier.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 chunk +4 lines, -4 lines 0 comments Download
D test/cctest/compiler/test-changes-lowering.cc View 1 chunk +0 lines, -183 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +17 lines, -23 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941673002/1
4 years, 7 months ago (2016-05-02 06:18:56 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-02 06:22:54 UTC) #4
Igor Sheludko
lgtm
4 years, 7 months ago (2016-05-02 07:39:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941673002/20001
4 years, 7 months ago (2016-05-02 08:18:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 08:41:32 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ceca5ae308bddda166651c654f96d71d74f617d0 Cr-Commit-Position: refs/heads/master@{#35924}
4 years, 7 months ago (2016-05-02 08:42:12 UTC) #14
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1942733002/ by machenbach@chromium.org. ...
4 years, 7 months ago (2016-05-02 09:28:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941673002/40001
4 years, 7 months ago (2016-05-02 09:59:36 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-02 10:23:07 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 10:23:53 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4aa02441dadec2b1cf60f69ba5c30a4a89df576b
Cr-Commit-Position: refs/heads/master@{#35929}

Powered by Google App Engine
This is Rietveld 408576698