Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: test/cctest/compiler/test-changes-lowering.cc

Issue 1941673002: [turbofan] Remove left-over change bits from ChangeLowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Don't mess with the regions yet Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <limits>
6
7 #include "src/ast/scopes.h"
8 #include "src/compiler/change-lowering.h"
9 #include "src/compiler/control-builders.h"
10 #include "src/compiler/js-graph.h"
11 #include "src/compiler/node-properties.h"
12 #include "src/compiler/pipeline.h"
13 #include "src/compiler/select-lowering.h"
14 #include "src/compiler/simplified-lowering.h"
15 #include "src/compiler/typer.h"
16 #include "src/compiler/verifier.h"
17 #include "src/execution.h"
18 #include "src/globals.h"
19 #include "src/parsing/parser.h"
20 #include "src/parsing/rewriter.h"
21 #include "test/cctest/cctest.h"
22 #include "test/cctest/compiler/codegen-tester.h"
23 #include "test/cctest/compiler/function-tester.h"
24 #include "test/cctest/compiler/graph-builder-tester.h"
25 #include "test/cctest/compiler/value-helper.h"
26
27 namespace v8 {
28 namespace internal {
29 namespace compiler {
30
31 template <typename ReturnType>
32 class ChangesLoweringTester : public GraphBuilderTester<ReturnType> {
33 public:
34 explicit ChangesLoweringTester(MachineType p0 = MachineType::None())
35 : GraphBuilderTester<ReturnType>(p0),
36 javascript(this->zone()),
37 jsgraph(this->isolate(), this->graph(), this->common(), &javascript,
38 nullptr, this->machine()),
39 function(Handle<JSFunction>::null()) {}
40
41 JSOperatorBuilder javascript;
42 JSGraph jsgraph;
43 Handle<JSFunction> function;
44
45 Node* start() { return this->graph()->start(); }
46
47 template <typename T>
48 T* CallWithPotentialGC() {
49 // TODO(titzer): we wrap the code in a JSFunction here to reuse the
50 // JSEntryStub; that could be done with a special prologue or other stub.
51 if (function.is_null()) {
52 function = FunctionTester::ForMachineGraph(this->graph());
53 }
54 Handle<Object>* args = NULL;
55 MaybeHandle<Object> result =
56 Execution::Call(this->isolate(), function, factory()->undefined_value(),
57 0, args, false);
58 return T::cast(*result.ToHandleChecked());
59 }
60
61 void StoreFloat64(Node* node, double* ptr) {
62 Node* ptr_node = this->PointerConstant(ptr);
63 this->Store(MachineType::Float64(), ptr_node, node);
64 }
65
66 Node* LoadInt32(int32_t* ptr) {
67 Node* ptr_node = this->PointerConstant(ptr);
68 return this->Load(MachineType::Int32(), ptr_node);
69 }
70
71 Node* LoadUint32(uint32_t* ptr) {
72 Node* ptr_node = this->PointerConstant(ptr);
73 return this->Load(MachineType::Uint32(), ptr_node);
74 }
75
76 Node* LoadFloat64(double* ptr) {
77 Node* ptr_node = this->PointerConstant(ptr);
78 return this->Load(MachineType::Float64(), ptr_node);
79 }
80
81 void CheckNumber(double expected, Object* number) {
82 CHECK(this->isolate()->factory()->NewNumber(expected)->SameValue(number));
83 }
84
85 void BuildAndLower(const Operator* op) {
86 // We build a graph by hand here, because the raw machine assembler
87 // does not add the correct control and effect nodes.
88 Node* p0 = this->Parameter(0);
89 Node* change = this->graph()->NewNode(op, p0);
90 Node* ret = this->graph()->NewNode(this->common()->Return(), change,
91 this->start(), this->start());
92 Node* end = this->graph()->NewNode(this->common()->End(1), ret);
93 this->graph()->SetEnd(end);
94 LowerChange(change);
95 }
96
97 void BuildStoreAndLower(const Operator* op, const Operator* store_op,
98 void* location) {
99 // We build a graph by hand here, because the raw machine assembler
100 // does not add the correct control and effect nodes.
101 Node* p0 = this->Parameter(0);
102 Node* change = this->graph()->NewNode(op, p0);
103 Node* store = this->graph()->NewNode(
104 store_op, this->PointerConstant(location), this->Int32Constant(0),
105 change, this->start(), this->start());
106 Node* ret = this->graph()->NewNode(
107 this->common()->Return(), this->Int32Constant(0), store, this->start());
108 Node* end = this->graph()->NewNode(this->common()->End(1), ret);
109 this->graph()->SetEnd(end);
110 LowerChange(change);
111 }
112
113 void BuildLoadAndLower(const Operator* op, const Operator* load_op,
114 void* location) {
115 // We build a graph by hand here, because the raw machine assembler
116 // does not add the correct control and effect nodes.
117 Node* load = this->graph()->NewNode(
118 load_op, this->PointerConstant(location), this->Int32Constant(0),
119 this->start(), this->start());
120 Node* change = this->graph()->NewNode(op, load);
121 Node* ret = this->graph()->NewNode(this->common()->Return(), change,
122 this->start(), this->start());
123 Node* end = this->graph()->NewNode(this->common()->End(1), ret);
124 this->graph()->SetEnd(end);
125 LowerChange(change);
126 }
127
128 void LowerChange(Node* change) {
129 // Run the graph reducer with changes lowering on a single node.
130 Typer typer(this->isolate(), this->graph());
131 typer.Run();
132 ChangeLowering change_lowering(&jsgraph);
133 SelectLowering select_lowering(this->graph(), this->common());
134 GraphReducer reducer(this->zone(), this->graph());
135 reducer.AddReducer(&change_lowering);
136 reducer.AddReducer(&select_lowering);
137 reducer.ReduceNode(change);
138 Verifier::Run(this->graph(), Verifier::UNTYPED);
139 }
140
141 Factory* factory() { return this->isolate()->factory(); }
142 Heap* heap() { return this->isolate()->heap(); }
143 };
144
145
146 TEST(RunChangeBoolToBit) {
147 ChangesLoweringTester<int32_t> t(MachineType::AnyTagged());
148 t.BuildAndLower(t.simplified()->ChangeBoolToBit());
149
150 {
151 Object* true_obj = t.heap()->true_value();
152 int32_t result = t.Call(true_obj);
153 CHECK_EQ(1, result);
154 }
155
156 {
157 Object* false_obj = t.heap()->false_value();
158 int32_t result = t.Call(false_obj);
159 CHECK_EQ(0, result);
160 }
161 }
162
163
164 TEST(RunChangeBitToBool) {
165 ChangesLoweringTester<Object*> t(MachineType::Int32());
166 t.BuildAndLower(t.simplified()->ChangeBitToBool());
167
168 {
169 Object* result = t.Call(1);
170 Object* true_obj = t.heap()->true_value();
171 CHECK_EQ(true_obj, result);
172 }
173
174 {
175 Object* result = t.Call(0);
176 Object* false_obj = t.heap()->false_value();
177 CHECK_EQ(false_obj, result);
178 }
179 }
180
181 } // namespace compiler
182 } // namespace internal
183 } // namespace v8
OLDNEW
« no previous file with comments | « test/cctest/compiler/graph-builder-tester.h ('k') | test/cctest/compiler/test-representation-change.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698