Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1941463002: Removes the restriction placed on the role of the accessibility object when calling the next/previo… (Closed)

Created:
4 years, 7 months ago by nektarios
Modified:
4 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, haraken, blink-reviews, nektarios, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes the restriction placed on the role of the accessibility object when calling the next/previousOnLine Blink APIs. R=dmazzoni@chromium.org BUG=605670 Committed: https://crrev.com/5f4c668a1c89d82ba0fed9cc8912308b69e068f1 Cr-Commit-Position: refs/heads/master@{#390827}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comment and discovered that images don't work. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -53 lines) Patch
M content/browser/accessibility/browser_accessibility.cc View 2 chunks +16 lines, -22 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 1 chunk +6 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/inline-text-box-next-on-line.html View 1 2 chunks +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 2 chunks +22 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nektarios
4 years, 7 months ago (2016-04-29 22:06:26 UTC) #1
dmazzoni
lgtm https://codereview.chromium.org/1941463002/diff/1/content/renderer/accessibility/blink_ax_tree_source.cc File content/renderer/accessibility/blink_ax_tree_source.cc (right): https://codereview.chromium.org/1941463002/diff/1/content/renderer/accessibility/blink_ax_tree_source.cc#newcode406 content/renderer/accessibility/blink_ax_tree_source.cc:406: if (!src.nextOnLine().isDetached()) { nit: remove indent
4 years, 7 months ago (2016-04-29 23:02:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941463002/20001
4 years, 7 months ago (2016-04-30 00:05:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-30 01:08:06 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:30:44 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5f4c668a1c89d82ba0fed9cc8912308b69e068f1
Cr-Commit-Position: refs/heads/master@{#390827}

Powered by Google App Engine
This is Rietveld 408576698