content/renderer/accessibility/blink_ax_tree_source.cc - Issue 1941463002: Removes the restriction placed on the role of the accessibility object when calling the next/previo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 1941463002: Removes the restriction placed on the role of the accessibility object when calling the next/previo… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment and discovered that images don't work. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility.cc ('k') | third_party/WebKit/LayoutTests/accessibility/inline-text-box-next-on-line.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index 6a1daa4191bb4627f570c9539545a5aefee753ad..dd756c4b3e936afd44baf574b1dc8733a2d04dde 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -403,18 +403,13 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

src.keyboardShortcut().utf8());

}

- if (dst->role == ui::AX_ROLE_STATIC_TEXT ||

- dst->role == ui::AX_ROLE_LINE_BREAK ||

- dst->role == ui::AX_ROLE_INLINE_TEXT_BOX) {

- if (!src.nextOnLine().isDetached()) {

- dst->AddIntAttribute(ui::AX_ATTR_NEXT_ON_LINE_ID,

- src.nextOnLine().axID());

- }

+ if (!src.nextOnLine().isDetached()) {

+ dst->AddIntAttribute(ui::AX_ATTR_NEXT_ON_LINE_ID, src.nextOnLine().axID());

+ }

- if (!src.previousOnLine().isDetached()) {

- dst->AddIntAttribute(ui::AX_ATTR_PREVIOUS_ON_LINE_ID,

- src.previousOnLine().axID());

- }

+ if (!src.previousOnLine().isDetached()) {

+ dst->AddIntAttribute(ui::AX_ATTR_PREVIOUS_ON_LINE_ID,

+ src.previousOnLine().axID());

}

if (!src.ariaActiveDescendant().isDetached()) {