Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1941433002: Adding default_exe_manifest to two binaries (Closed)

Created:
4 years, 7 months ago by brucedawson
Modified:
4 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adding default_exe_manifest to two binaries gn builds are missing Windows manifests for d8.exe and mksnapshot.exe. These manifests are necessary in order to get predictable behavior on Windows. LOG=N BUG=602505 Committed: https://crrev.com/7741feb2ca5fadca29ebb7f6c0ae363ba94ca71b Cr-Commit-Position: refs/heads/master@{#35943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
PTAL. See https://codereview.chromium.org/1906193002 for another example of this type of change.
4 years, 7 months ago (2016-04-29 21:22:49 UTC) #2
Michael Achenbach
lgtm
4 years, 7 months ago (2016-05-01 15:06:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941433002/1
4 years, 7 months ago (2016-05-02 16:19:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 16:46:18 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 16:47:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7741feb2ca5fadca29ebb7f6c0ae363ba94ca71b
Cr-Commit-Position: refs/heads/master@{#35943}

Powered by Google App Engine
This is Rietveld 408576698