Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1906193002: Fixing gn manifests for many executables (Closed)

Created:
4 years, 8 months ago by brucedawson
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, blink-reviews, kinuko+watch, native-client-reviews_googlegroups.com, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing gn manifests for many executables Many executables are missing embedded manifest files when built with gn, and remoting_desktop is missing the OS compatibility information. This change cleans up most of these problems. BUG=602505 Committed: https://crrev.com/3eee0c968569c726bd8ca26c0a70b929b87f1427 Cr-Commit-Position: refs/heads/master@{#389306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -22 lines) Patch
M build/secondary/third_party/crashpad/crashpad/tools/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/nacl_host/test/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/host/BUILD.gn View 9 chunks +37 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/protobuf/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/yasm/BUILD.gn View 7 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
This gets *most* of the executables that we build to have manifests, but not all. ...
4 years, 8 months ago (2016-04-22 00:29:50 UTC) #2
brettw
lgtm
4 years, 8 months ago (2016-04-22 20:40:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906193002/1
4 years, 8 months ago (2016-04-22 22:40:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 23:47:14 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 23:48:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3eee0c968569c726bd8ca26c0a70b929b87f1427
Cr-Commit-Position: refs/heads/master@{#389306}

Powered by Google App Engine
This is Rietveld 408576698