Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: src/compiler/effect-control-linearizer.cc

Issue 1941373002: [turbofan] Remove atomic regions during effect/control linearization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@Jaro
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/effect-control-linearizer.cc
diff --git a/src/compiler/effect-control-linearizer.cc b/src/compiler/effect-control-linearizer.cc
index c511741bd33e50dea8f48f860b45179fe1734f86..0f6537fa586bf94206ef9c013965c47e166b6c82 100644
--- a/src/compiler/effect-control-linearizer.cc
+++ b/src/compiler/effect-control-linearizer.cc
@@ -290,12 +290,7 @@ void EffectControlLinearizer::ProcessNode(Node* node, Node** effect,
node->opcode() == IrOpcode::kBeginRegion) {
// Update the value uses to the value input of the finish node and
// the effect uses to the effect input.
-
- // TODO(jarin) Enable this once we make sure everything with side effects
- // is marked as effectful.
- if (false) {
- return RemoveRegionNode(node);
- }
+ return RemoveRegionNode(node);
}
if (node->opcode() == IrOpcode::kIfSuccess) {
@@ -908,7 +903,6 @@ EffectControlLinearizer::LowerObjectIsUndetectable(Node* node, Node* effect,
EffectControlLinearizer::ValueEffectControl
EffectControlLinearizer::AllocateHeapNumberWithValue(Node* value, Node* effect,
Node* control) {
- effect = graph()->NewNode(common()->BeginRegion(), effect);
Node* result = effect = graph()->NewNode(
simplified()->Allocate(NOT_TENURED),
jsgraph()->Int32Constant(HeapNumber::kSize), effect, control);
@@ -918,7 +912,6 @@ EffectControlLinearizer::AllocateHeapNumberWithValue(Node* value, Node* effect,
effect = graph()->NewNode(
simplified()->StoreField(AccessBuilder::ForHeapNumberValue()), result,
value, effect, control);
- result = effect = graph()->NewNode(common()->FinishRegion(), result, effect);
return ValueEffectControl(result, effect, control);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698