[turbofan] Remove atomic regions during effect/control linearization.

src/compiler/effect-control-linearizer.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/effect-control-linearizer.h"
 
 #include "src/code-factory.h"
 #include "src/compiler/access-builder.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/linkage.h"
@@ skipping 272 matching lines @@
   if (TryWireInStateEffect(node, effect, control)) {
     return;
   }
 
   // Remove the end markers of 'atomic' allocation region because the
   // region should be wired-in now.
   if (node->opcode() == IrOpcode::kFinishRegion ||
       node->opcode() == IrOpcode::kBeginRegion) {
     // Update the value uses to the value input of the finish node and
     // the effect uses to the effect input.
-
-    // TODO(jarin) Enable this once we make sure everything with side effects
-    // is marked as effectful.
-    if (false) {
-      return RemoveRegionNode(node);
-    }
+    return RemoveRegionNode(node);
   }
 
   if (node->opcode() == IrOpcode::kIfSuccess) {
     // We always schedule IfSuccess with its call, so skip it here.
     DCHECK_EQ(IrOpcode::kCall, node->InputAt(0)->opcode());
     // The IfSuccess node should not belong to an exceptional call node
     // because such IfSuccess nodes should only start a basic block (and
     // basic block start nodes are not handled in the ProcessNode method).
     DCHECK(!NodeProperties::IsExceptionalCall(node->InputAt(0)));
     return;
@@ skipping 592 matching lines @@
   effect = graph()->NewNode(common()->EffectPhi(2), etrue, efalse, control);
   value = graph()->NewNode(common()->Phi(MachineRepresentation::kBit, 2), vtrue,
                            vfalse, control);
 
   return ValueEffectControl(value, effect, control);
 }
 
 EffectControlLinearizer::ValueEffectControl
 EffectControlLinearizer::AllocateHeapNumberWithValue(Node* value, Node* effect,
                                                      Node* control) {
-  effect = graph()->NewNode(common()->BeginRegion(), effect);
   Node* result = effect = graph()->NewNode(
       simplified()->Allocate(NOT_TENURED),
       jsgraph()->Int32Constant(HeapNumber::kSize), effect, control);
   effect = graph()->NewNode(simplified()->StoreField(AccessBuilder::ForMap()),
                             result, jsgraph()->HeapNumberMapConstant(), effect,
                             control);
   effect = graph()->NewNode(
       simplified()->StoreField(AccessBuilder::ForHeapNumberValue()), result,
       value, effect, control);
-  result = effect = graph()->NewNode(common()->FinishRegion(), result, effect);
   return ValueEffectControl(result, effect, control);
 }
 
 Node* EffectControlLinearizer::ChangeInt32ToSmi(Node* value) {
   if (machine()->Is64()) {
     value = graph()->NewNode(machine()->ChangeInt32ToInt64(), value);
   }
   return graph()->NewNode(machine()->WordShl(), value, SmiShiftBitsConstant());
 }
 
@@ skipping 32 matching lines @@
   return jsgraph()->Int32Constant(Smi::kMaxValue);
 }
 
 Node* EffectControlLinearizer::SmiShiftBitsConstant() {
   return jsgraph()->IntPtrConstant(kSmiShiftSize + kSmiTagSize);
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8