ios/chrome/browser/passwords/password_controller.h - Issue 1941363002: PasswordController should give up on WebState destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/passwords/password_controller.h

Issue 1941363002: PasswordController should give up on WebState destruction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: isBeingDestroyed Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/passwords/password_controller.h

diff --git a/ios/chrome/browser/passwords/password_controller.h b/ios/chrome/browser/passwords/password_controller.h

index e98a09a6d17317a9fd6d08ad326af356d7a107b2..4a4de357f57a12a9ac24997ed402dcf835899aa6 100644

--- a/ios/chrome/browser/passwords/password_controller.h

+++ b/ios/chrome/browser/passwords/password_controller.h

@@ -48,6 +48,9 @@ class PasswordManagerDriver;

@property(readonly)

password_manager::PasswordManagerDriver* passwordManagerDriver;

+// This is set to YES as soon as the associated WebState is destroyed.

+@property(readonly) BOOL isBeingDestroyed;

Eugene But (OOO till 7-30) 2016/05/03 17:49:49 Does this need to be public?

vabr (Chromium) 2016/05/04 15:03:46 No, good point. I moved it to the .mm file.

// |webState| should not be nil.

- (instancetype)initWithWebState:(web::WebState*)webState

passwordsUiDelegate:(id<PasswordsUiDelegate>)UIDelegate;

« no previous file with comments | « no previous file | ios/chrome/browser/passwords/password_controller.mm » ('j') | ios/chrome/browser/passwords/password_controller.mm » ('J')