PasswordController should give up on WebState destruction

ios/chrome/browser/passwords/password_controller.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #ifndef IOS_CHROME_BROWSER_PASSWORDS_PASSWORD_CONTROLLER_H_
 #define IOS_CHROME_BROWSER_PASSWORDS_PASSWORD_CONTROLLER_H_
 
 #import <Foundation/NSObject.h>
 
 #include <memory>
 
@@ skipping 30 matching lines @@
     password_manager::PasswordGenerationManager* passwordGenerationManager;
 
 // The PasswordManagerClient owned by this PasswordController.
 @property(readonly)
     password_manager::PasswordManagerClient* passwordManagerClient;
 
 // The PasswordManagerDriver owned by this PasswordController.
 @property(readonly)
     password_manager::PasswordManagerDriver* passwordManagerDriver;
 
+// This is set to YES as soon as the associated WebState is destroyed.
+@property(readonly) BOOL isBeingDestroyed;

[Eugene But (OOO till 7-30), 2016/05/03 17:49:49]

Does this need to be public?

[vabr (Chromium), 2016/05/04 15:03:46]

No, good point. I moved it to the .mm file.

+
 // |webState| should not be nil.
 - (instancetype)initWithWebState:(web::WebState*)webState
              passwordsUiDelegate:(id<PasswordsUiDelegate>)UIDelegate;
 
 // This is just for testing.
 - (instancetype)
    initWithWebState:(web::WebState*)webState
 passwordsUiDelegate:(id<PasswordsUiDelegate>)UIDelegate
              client:(std::unique_ptr<password_manager::PasswordManagerClient>)
                         passwordManagerClient NS_DESIGNATED_INITIALIZER;
 
 - (instancetype)init NS_UNAVAILABLE;
 
 // Releases all tab-specific members. Must be called when the Tab is closing,
 // otherwise invalid memory might be accessed during destruction.
 - (void)detach;
 
 // Uses JavaScript to find password forms using the |webState_| and fills
 // them with the |username| and |password|. |completionHandler|, if not nil,
 // is called once per form filled.
 - (void)findAndFillPasswordForms:(NSString*)username
                         password:(NSString*)password
                completionHandler:(void (^)(BOOL))completionHandler;
 
 @end
 
 #endif  // IOS_CHROME_BROWSER_PASSWORDS_PASSWORD_CONTROLLER_H_