JobController 1: Adding a new class HttpStreamFactoryImpl::JobController

net/http/http_basic_stream.h

Index: net/http/http_basic_stream.h
diff --git a/net/http/http_basic_stream.h b/net/http/http_basic_stream.h
index 1bb9a0be7cc4c67ccbe6b81fa568b1583cca3d65..cb3ea2fd517dcdf9549a858562a6dc0197873995 100644
--- a/net/http/http_basic_stream.h
+++ b/net/http/http_basic_stream.h
@@ -14,6 +14,7 @@
 #include <string>
 
 #include "base/macros.h"
+#include "net/base/net_export.h"
 #include "net/http/http_basic_state.h"
 #include "net/http/http_stream.h"
 
@@ -27,7 +28,7 @@ class HttpRequestHeaders;
 class HttpStreamParser;
 class IOBuffer;
 
-class HttpBasicStream : public HttpStream {
+class NET_EXPORT_PRIVATE HttpBasicStream : public HttpStream {

[Ryan Hamilton, 2016/06/13 19:25:26]

Out of curiosity, why is this required?

[Zhongyi Shi, 2016/06/14 22:20:57]

Cauz we now use TestJob in job_controller_unittests. We call
JobController::OnStreamReady() to indicate Job has the stream ready but really
without a stream set in TestJob. Thus we need to manually create a
HttpBasicStream, and feed in to the Job before calling JobContoller  

  public:
   // Constructs a new HttpBasicStream. InitializeStream must be called to
   // initialize it correctly.