JobController 1: Adding a new class HttpStreamFactoryImpl::JobController

net/http/http_basic_stream.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // HttpBasicStream is a simple implementation of HttpStream.  It assumes it is
 // not sharing a sharing with any other HttpStreams, therefore it just reads and
 // writes directly to the Http Stream.
 
 #ifndef NET_HTTP_HTTP_BASIC_STREAM_H_
 #define NET_HTTP_HTTP_BASIC_STREAM_H_
 
 #include <stdint.h>
 
 #include <string>
 
 #include "base/macros.h"
+#include "net/base/net_export.h"
 #include "net/http/http_basic_state.h"
 #include "net/http/http_stream.h"
 
 namespace net {
 
 class BoundNetLog;
 class ClientSocketHandle;
 class HttpResponseInfo;
 struct HttpRequestInfo;
 class HttpRequestHeaders;
 class HttpStreamParser;
 class IOBuffer;
 
-class HttpBasicStream : public HttpStream {
+class NET_EXPORT_PRIVATE HttpBasicStream : public HttpStream {

[Ryan Hamilton, 2016/06/13 19:25:26]

Out of curiosity, why is this required?

[Zhongyi Shi, 2016/06/14 22:20:57]

Cauz we now use TestJob in job_controller_unittests. We call
JobController::OnStreamReady() to indicate Job has the stream ready but really
without a stream set in TestJob. Thus we need to manually create a
HttpBasicStream, and feed in to the Job before calling JobContoller  

  public:
   // Constructs a new HttpBasicStream. InitializeStream must be called to
   // initialize it correctly.
   HttpBasicStream(ClientSocketHandle* connection, bool using_proxy);
   ~HttpBasicStream() override;
 
   // HttpStream methods:
   int InitializeStream(const HttpRequestInfo* request_info,
                        RequestPriority priority,
                        const BoundNetLog& net_log,
@@ skipping 48 matching lines @@
   HttpStreamParser* parser() const { return state_.parser(); }
 
   HttpBasicState state_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpBasicStream);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_BASIC_STREAM_H_