Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1940773002: Prevent markContainerChainForLayout to scheduleRelayout() if isInPerformLayout() (Closed)

Created:
4 years, 7 months ago by kojii
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Prevent markContainerChainForLayout to scheduleRelayout() if isInPerformLayout() When we're in layout, markContainerChainForLayout() is marking a descendant as needing layout with the intention of visiting it during this layout. We shouldn't be scheduling it to be laid out later. Also, schedduleRelayout() must not be called while iterating FrameView::m_layoutSubtreeRootList. BUG=602908, 589773 Review URL: https://codereview.chromium.org/1906803002 Cr-Commit-Position: refs/heads/master@{#389691} (cherry picked from commit 1a0aa2dff16abbd9bc7f906b4d807766668bde17) Committed: https://chromium.googlesource.com/chromium/src/+/90b37d4b2f759e1fe6b8de74abd6f6429c16f723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
kojii
4 years, 7 months ago (2016-05-02 05:01:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
90b37d4b2f759e1fe6b8de74abd6f6429c16f723.

Powered by Google App Engine
This is Rietveld 408576698