Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1940773002: Prevent markContainerChainForLayout to scheduleRelayout() if isInPerformLayout() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1754 matching lines...) Expand 10 before | Expand all | Expand 10 after
1765 continue; 1765 continue;
1766 } 1766 }
1767 LayoutState layoutState(*root); 1767 LayoutState layoutState(*root);
1768 root->layout(); 1768 root->layout();
1769 } 1769 }
1770 } 1770 }
1771 1771
1772 void FrameView::scheduleRelayout() 1772 void FrameView::scheduleRelayout()
1773 { 1773 {
1774 ASSERT(m_frame->view() == this); 1774 ASSERT(m_frame->view() == this);
1775 RELEASE_ASSERT(!isInPerformLayout());
1775 1776
1776 if (!m_layoutSchedulingEnabled) 1777 if (!m_layoutSchedulingEnabled)
1777 return; 1778 return;
1778 if (!needsLayout()) 1779 if (!needsLayout())
1779 return; 1780 return;
1780 if (!m_frame->document()->shouldScheduleLayout()) 1781 if (!m_frame->document()->shouldScheduleLayout())
1781 return; 1782 return;
1782 TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "Invali dateLayout", TRACE_EVENT_SCOPE_THREAD, "data", InspectorInvalidateLayoutEvent::d ata(m_frame.get())); 1783 TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "Invali dateLayout", TRACE_EVENT_SCOPE_THREAD, "data", InspectorInvalidateLayoutEvent::d ata(m_frame.get()));
1783 1784
1784 clearLayoutSubtreeRootsAndMarkContainingBlocks(); 1785 clearLayoutSubtreeRootsAndMarkContainingBlocks();
1785 1786
1786 if (m_hasPendingLayout) 1787 if (m_hasPendingLayout)
1787 return; 1788 return;
1788 m_hasPendingLayout = true; 1789 m_hasPendingLayout = true;
1789 1790
1790 if (!shouldThrottleRendering()) 1791 if (!shouldThrottleRendering())
1791 page()->animator().scheduleVisualUpdate(m_frame.get()); 1792 page()->animator().scheduleVisualUpdate(m_frame.get());
1792 } 1793 }
1793 1794
1794 void FrameView::scheduleRelayoutOfSubtree(LayoutObject* relayoutRoot) 1795 void FrameView::scheduleRelayoutOfSubtree(LayoutObject* relayoutRoot)
1795 { 1796 {
1796 ASSERT(m_frame->view() == this); 1797 ASSERT(m_frame->view() == this);
1798 RELEASE_ASSERT(!isInPerformLayout());
1797 1799
1798 // FIXME: Should this call shouldScheduleLayout instead? 1800 // FIXME: Should this call shouldScheduleLayout instead?
1799 if (!m_frame->document()->isActive()) 1801 if (!m_frame->document()->isActive())
1800 return; 1802 return;
1801 1803
1802 LayoutView* layoutView = this->layoutView(); 1804 LayoutView* layoutView = this->layoutView();
1803 if (layoutView && layoutView->needsLayout()) { 1805 if (layoutView && layoutView->needsLayout()) {
1804 if (relayoutRoot) 1806 if (relayoutRoot)
1805 relayoutRoot->markContainerChainForLayout(false); 1807 relayoutRoot->markContainerChainForLayout(false);
1806 return; 1808 return;
(...skipping 2329 matching lines...) Expand 10 before | Expand all | Expand 10 after
4136 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling); 4138 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling);
4137 } 4139 }
4138 4140
4139 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const 4141 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const
4140 { 4142 {
4141 ASSERT(layoutView()); 4143 ASSERT(layoutView());
4142 return *layoutView(); 4144 return *layoutView();
4143 } 4145 }
4144 4146
4145 } // namespace blink 4147 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698