Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1940753002: Enable YouCompleteMe and :CrCompile to find GN build directory (Closed)

Created:
4 years, 7 months ago by please use gerrit instead
Modified:
4 years, 7 months ago
Reviewers:
asanka
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable YouCompleteMe and :CrCompile to find GN build directory BUG=608225 Committed: https://crrev.com/e5627eab6ddd721fb0b7e33fd289ebb418a67025 Cr-Commit-Position: refs/heads/master@{#390979}

Patch Set 1 #

Patch Set 2 : Change from 'out/Debug' to 'out/gn' directory in tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M tools/vim/ninja-build.vim View 2 chunks +7 lines, -7 lines 0 comments Download
M tools/vim/ninja_output.py View 3 chunks +9 lines, -15 lines 0 comments Download
M tools/vim/tests/chromium.ycm_extra_conf_unittest.py View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
please use gerrit instead
asanka@, ptal.
4 years, 7 months ago (2016-05-01 23:45:50 UTC) #2
asanka
Could you update the tests in tests/ to use something other than Debug?
4 years, 7 months ago (2016-05-02 13:43:05 UTC) #3
asanka
On 2016/05/02 at 13:43:05, asanka wrote: > Could you update the tests in tests/ to ...
4 years, 7 months ago (2016-05-02 13:44:32 UTC) #4
please use gerrit instead
On 2016/05/02 at 13:43:05, asanka wrote: > Could you update the tests in tests/ to ...
4 years, 7 months ago (2016-05-02 16:15:39 UTC) #5
asanka
lgtm
4 years, 7 months ago (2016-05-02 16:36:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940753002/20001
4 years, 7 months ago (2016-05-02 16:46:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 17:22:16 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 17:23:28 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5627eab6ddd721fb0b7e33fd289ebb418a67025
Cr-Commit-Position: refs/heads/master@{#390979}

Powered by Google App Engine
This is Rietveld 408576698