Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: tools/vim/ninja-build.vim

Issue 1940753002: Enable YouCompleteMe and :CrCompile to find GN build directory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change from 'out/Debug' to 'out/gn' directory in tests. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/vim/ninja_output.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/vim/ninja-build.vim
diff --git a/tools/vim/ninja-build.vim b/tools/vim/ninja-build.vim
index 70e5a83cf2194b694a4745472fa329c9d2853363..76e2049f7919dc6b3a32a5ddc3f9793f727dc807 100644
--- a/tools/vim/ninja-build.vim
+++ b/tools/vim/ninja-build.vim
@@ -41,17 +41,17 @@ def path_to_source_root():
return candidate
-def path_to_build_dir(configuration):
- """Returns <chrome_root>/<output_dir>/(Release|Debug)."""
+def path_to_build_dir():
+ """Returns <chrome_root>/<output_dir>/(Release|Debug|<other>)."""
chrome_root = path_to_source_root()
sys.path.append(os.path.join(chrome_root, 'tools', 'vim'))
from ninja_output import GetNinjaOutputDirectory
- return GetNinjaOutputDirectory(chrome_root, configuration)
+ return GetNinjaOutputDirectory(chrome_root)
-def compute_ninja_command_for_current_buffer(configuration=None):
+def compute_ninja_command_for_current_buffer():
"""Returns the shell command to compile the file in the current buffer."""
- build_dir = path_to_build_dir(configuration)
+ build_dir = path_to_build_dir()
# ninja needs filepaths for the ^ syntax to be relative to the
# build directory.
@@ -65,8 +65,8 @@ def compute_ninja_command_for_current_buffer(configuration=None):
vim.command('return "%s"' % build_cmd)
-def compute_ninja_command_for_targets(targets='', configuration=None):
- build_cmd = ' '.join(['ninja', '-C', path_to_build_dir(configuration),
+def compute_ninja_command_for_targets(targets=''):
+ build_cmd = ' '.join(['ninja', '-C', path_to_build_dir(),
targets])
vim.command('return "%s"' % build_cmd)
endpython
« no previous file with comments | « no previous file | tools/vim/ninja_output.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698