Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1940643002: Avoid infinite loop in RegExp.prototype[Symbol.split] (Closed)

Created:
4 years, 7 months ago by adamk
Modified:
4 years, 7 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid infinite loop in RegExp.prototype[Symbol.split] Our implementation of the spec got one comparison wrong, at step 19.d.iii (we were comparing against 'q' instead of 'p'). R=littledan@chromium.org BUG=chromium:607566 LOG=n Committed: https://crrev.com/96746cc7c7abf85133dd79c889d79a900c46a610 Cr-Commit-Position: refs/heads/master@{#35947}

Patch Set 1 #

Patch Set 2 : Remove another fail expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/js/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test262/test262.status View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
adamk
4 years, 7 months ago (2016-04-29 23:26:12 UTC) #1
Dan Ehrenberg
lgtm
4 years, 7 months ago (2016-04-30 01:08:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940643002/20001
4 years, 7 months ago (2016-05-02 17:10:24 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 17:32:58 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 17:33:39 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/96746cc7c7abf85133dd79c889d79a900c46a610
Cr-Commit-Position: refs/heads/master@{#35947}

Powered by Google App Engine
This is Rietveld 408576698