src/js/regexp.js - Issue 1940643002: Avoid infinite loop in RegExp.prototype[Symbol.split]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/regexp.js

Issue 1940643002: Avoid infinite loop in RegExp.prototype[Symbol.split] (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove another fail expectation Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/regexp.js

diff --git a/src/js/regexp.js b/src/js/regexp.js

index 131e08ed4b399de9e4c7b55082ee2de89683ae81..28492609234cf712edeb5045836ac7185b13f77a 100644

--- a/src/js/regexp.js

+++ b/src/js/regexp.js

@@ -513,7 +513,7 @@ function RegExpSubclassSplit(string, limit) {

stringIndex += AdvanceStringIndex(string, stringIndex, unicode);

} else {

var end = MinSimple(TO_LENGTH(splitter.lastIndex), size);

- if (end === stringIndex) {

+ if (end === prevStringIndex) {

stringIndex += AdvanceStringIndex(string, stringIndex, unicode);

} else {

%AddElement(

« no previous file with comments | « no previous file | test/test262/test262.status » ('j') | no next file with comments »