Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1940393002: Start building Harfbuzz+Skia example (Closed)

Created:
4 years, 7 months ago by hal.canary
Modified:
4 years, 7 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org, aam, behdad_google
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Start building HarfBuzz+Skia example (prevent bitrot in example code) tools/using_skia_and_harfbuzz.cpp was written by aam@: https://github.com/aam/skiaex update HarfBuzz to latest release: 1.2.7 BUG=skia:4742 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1940393002 Committed: https://skia.googlesource.com/skia/+/00d44e014c805d06a59a74cd744e24482c218e9b

Patch Set 1 : 2016-05-03 (Tuesday) 16:45:25 EDT #

Total comments: 1

Patch Set 2 : 2016-05-03 (Tuesday) 17:58:47 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4417 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
A gyp/harfbuzz.gyp View 1 chunk +61 lines, -0 lines 0 comments Download
M gyp/tools.gyp View 2 chunks +14 lines, -0 lines 0 comments Download
A third_party/harfbuzz/README View 1 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/harfbuzz/hb-buffer-deserialize-json.hh View 1 chunk +643 lines, -0 lines 0 comments Download
A third_party/harfbuzz/hb-buffer-deserialize-text.hh View 1 chunk +571 lines, -0 lines 0 comments Download
A third_party/harfbuzz/hb-ot-shape-complex-indic-machine.hh View 1 chunk +1762 lines, -0 lines 0 comments Download
A third_party/harfbuzz/hb-ot-shape-complex-myanmar-machine.hh View 1 chunk +400 lines, -0 lines 0 comments Download
A third_party/harfbuzz/hb-ot-shape-complex-use-machine.hh View 1 chunk +548 lines, -0 lines 0 comments Download
A third_party/harfbuzz/hb-version.h View 1 chunk +66 lines, -0 lines 0 comments Download
A tools/using_skia_and_harfbuzz.cpp View 1 chunk +310 lines, -0 lines 0 comments Download

Messages

Total messages: 45 (29 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940393002/1
4 years, 7 months ago (2016-05-03 19:09:07 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/8371)
4 years, 7 months ago (2016-05-03 19:13:07 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940393002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940393002/40001
4 years, 7 months ago (2016-05-03 19:56:56 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940393002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940393002/60001
4 years, 7 months ago (2016-05-03 19:59:27 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/2399)
4 years, 7 months ago (2016-05-03 20:03:14 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940393002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940393002/100001
4 years, 7 months ago (2016-05-03 20:13:17 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/2401)
4 years, 7 months ago (2016-05-03 20:16:08 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940393002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940393002/140001
4 years, 7 months ago (2016-05-03 20:22:17 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940393002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940393002/180001
4 years, 7 months ago (2016-05-03 20:35:28 UTC) #27
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/8340)
4 years, 7 months ago (2016-05-03 20:39:09 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940393002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940393002/200001
4 years, 7 months ago (2016-05-03 20:45:49 UTC) #33
hal.canary
reed@ wants this example code compiling on our our bots to prevent bitrot. PTAL.
4 years, 7 months ago (2016-05-03 20:59:20 UTC) #36
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 21:00:43 UTC) #38
bungeman-skia
It would be nice if this were a gm or something so we could track ...
4 years, 7 months ago (2016-05-03 21:28:52 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940393002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940393002/220001
4 years, 7 months ago (2016-05-03 21:59:19 UTC) #43
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 22:09:56 UTC) #45
Message was sent while issue was closed.
Committed patchset #2 (id:220001) as
https://skia.googlesource.com/skia/+/00d44e014c805d06a59a74cd744e24482c218e9b

Powered by Google App Engine
This is Rietveld 408576698