Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: components/policy/core/common/proxy_policy_provider_unittest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/proxy_policy_provider_unittest.cc
diff --git a/components/policy/core/common/proxy_policy_provider_unittest.cc b/components/policy/core/common/proxy_policy_provider_unittest.cc
index 76e13fb78f2d6fac07893f9b2f4a3a8d4da67628..ee91146b025715ad07a9ba8b42afc88317c85250 100644
--- a/components/policy/core/common/proxy_policy_provider_unittest.cc
+++ b/components/policy/core/common/proxy_policy_provider_unittest.cc
@@ -53,12 +53,9 @@ TEST_F(ProxyPolicyProviderTest, Init) {
TEST_F(ProxyPolicyProviderTest, Delegate) {
PolicyBundle bundle;
bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
- .Set("policy",
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
+ .Set("policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
POLICY_SOURCE_CLOUD,
- new base::StringValue("value"),
- NULL);
+ base::WrapUnique(new base::StringValue("value")), nullptr);
mock_provider_.UpdatePolicy(CopyBundle(bundle));
EXPECT_CALL(observer_, OnUpdatePolicy(&proxy_provider_));
@@ -68,12 +65,9 @@ TEST_F(ProxyPolicyProviderTest, Delegate) {
EXPECT_CALL(observer_, OnUpdatePolicy(&proxy_provider_));
bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
- .Set("policy",
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
+ .Set("policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
POLICY_SOURCE_CLOUD,
- new base::StringValue("new value"),
- NULL);
+ base::WrapUnique(new base::StringValue("new value")), nullptr);
mock_provider_.UpdatePolicy(CopyBundle(bundle));
Mock::VerifyAndClearExpectations(&observer_);
EXPECT_TRUE(bundle.Equals(proxy_provider_.policies()));

Powered by Google App Engine
This is Rietveld 408576698