Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: components/policy/core/common/proxy_policy_provider_unittest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/callback.h" 5 #include "base/callback.h"
6 #include "base/macros.h" 6 #include "base/macros.h"
7 #include "components/policy/core/common/external_data_fetcher.h" 7 #include "components/policy/core/common/external_data_fetcher.h"
8 #include "components/policy/core/common/mock_configuration_policy_provider.h" 8 #include "components/policy/core/common/mock_configuration_policy_provider.h"
9 #include "components/policy/core/common/policy_types.h" 9 #include "components/policy/core/common/policy_types.h"
10 #include "components/policy/core/common/proxy_policy_provider.h" 10 #include "components/policy/core/common/proxy_policy_provider.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 }; 46 };
47 47
48 TEST_F(ProxyPolicyProviderTest, Init) { 48 TEST_F(ProxyPolicyProviderTest, Init) {
49 EXPECT_TRUE(proxy_provider_.IsInitializationComplete(POLICY_DOMAIN_CHROME)); 49 EXPECT_TRUE(proxy_provider_.IsInitializationComplete(POLICY_DOMAIN_CHROME));
50 EXPECT_TRUE(PolicyBundle().Equals(proxy_provider_.policies())); 50 EXPECT_TRUE(PolicyBundle().Equals(proxy_provider_.policies()));
51 } 51 }
52 52
53 TEST_F(ProxyPolicyProviderTest, Delegate) { 53 TEST_F(ProxyPolicyProviderTest, Delegate) {
54 PolicyBundle bundle; 54 PolicyBundle bundle;
55 bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())) 55 bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
56 .Set("policy", 56 .Set("policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
57 POLICY_LEVEL_MANDATORY,
58 POLICY_SCOPE_USER,
59 POLICY_SOURCE_CLOUD, 57 POLICY_SOURCE_CLOUD,
60 new base::StringValue("value"), 58 base::WrapUnique(new base::StringValue("value")), nullptr);
61 NULL);
62 mock_provider_.UpdatePolicy(CopyBundle(bundle)); 59 mock_provider_.UpdatePolicy(CopyBundle(bundle));
63 60
64 EXPECT_CALL(observer_, OnUpdatePolicy(&proxy_provider_)); 61 EXPECT_CALL(observer_, OnUpdatePolicy(&proxy_provider_));
65 proxy_provider_.SetDelegate(&mock_provider_); 62 proxy_provider_.SetDelegate(&mock_provider_);
66 Mock::VerifyAndClearExpectations(&observer_); 63 Mock::VerifyAndClearExpectations(&observer_);
67 EXPECT_TRUE(bundle.Equals(proxy_provider_.policies())); 64 EXPECT_TRUE(bundle.Equals(proxy_provider_.policies()));
68 65
69 EXPECT_CALL(observer_, OnUpdatePolicy(&proxy_provider_)); 66 EXPECT_CALL(observer_, OnUpdatePolicy(&proxy_provider_));
70 bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string())) 67 bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
71 .Set("policy", 68 .Set("policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
72 POLICY_LEVEL_MANDATORY,
73 POLICY_SCOPE_USER,
74 POLICY_SOURCE_CLOUD, 69 POLICY_SOURCE_CLOUD,
75 new base::StringValue("new value"), 70 base::WrapUnique(new base::StringValue("new value")), nullptr);
76 NULL);
77 mock_provider_.UpdatePolicy(CopyBundle(bundle)); 71 mock_provider_.UpdatePolicy(CopyBundle(bundle));
78 Mock::VerifyAndClearExpectations(&observer_); 72 Mock::VerifyAndClearExpectations(&observer_);
79 EXPECT_TRUE(bundle.Equals(proxy_provider_.policies())); 73 EXPECT_TRUE(bundle.Equals(proxy_provider_.policies()));
80 74
81 EXPECT_CALL(observer_, OnUpdatePolicy(&proxy_provider_)); 75 EXPECT_CALL(observer_, OnUpdatePolicy(&proxy_provider_));
82 proxy_provider_.SetDelegate(NULL); 76 proxy_provider_.SetDelegate(NULL);
83 EXPECT_TRUE(PolicyBundle().Equals(proxy_provider_.policies())); 77 EXPECT_TRUE(PolicyBundle().Equals(proxy_provider_.policies()));
84 } 78 }
85 79
86 TEST_F(ProxyPolicyProviderTest, RefreshPolicies) { 80 TEST_F(ProxyPolicyProviderTest, RefreshPolicies) {
(...skipping 11 matching lines...) Expand all
98 Mock::VerifyAndClearExpectations(&observer_); 92 Mock::VerifyAndClearExpectations(&observer_);
99 Mock::VerifyAndClearExpectations(&mock_provider_); 93 Mock::VerifyAndClearExpectations(&mock_provider_);
100 94
101 EXPECT_CALL(observer_, OnUpdatePolicy(&proxy_provider_)); 95 EXPECT_CALL(observer_, OnUpdatePolicy(&proxy_provider_));
102 mock_provider_.UpdatePolicy( 96 mock_provider_.UpdatePolicy(
103 std::unique_ptr<PolicyBundle>(new PolicyBundle())); 97 std::unique_ptr<PolicyBundle>(new PolicyBundle()));
104 Mock::VerifyAndClearExpectations(&observer_); 98 Mock::VerifyAndClearExpectations(&observer_);
105 } 99 }
106 100
107 } // namespace policy 101 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698