Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1940003002: Skip all local elements when comparing after AST based resynth. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip all local elements when comparing after AST based resynth. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9e8723b6d2243dfabc0d39071fae9430fcba3bd5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -47 lines) Patch
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 3 chunks +1 line, -19 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 2 chunks +28 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 7 months ago (2016-05-02 21:59:50 UTC) #1
Paul Berry
lgtm
4 years, 7 months ago (2016-05-03 18:46:55 UTC) #2
scheglov
4 years, 7 months ago (2016-05-03 19:13:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9e8723b6d2243dfabc0d39071fae9430fcba3bd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698