Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1968)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_ast_test.dart

Issue 1940003002: Skip all local elements when comparing after AST based resynth. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart b/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
index 420b70f65f62bc943d2e22e8970e48ce56e4cd1b..214f6d545e0aa22bf62a3ad934d8e1fb70a6d4dc 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
@@ -66,7 +66,7 @@ class AstInferredTypeTest extends AbstractResynthesizeTest
}
@override
- void compareLocalVariableElementLists(ExecutableElement resynthesized,
+ void compareLocalElementsOfExecutable(ExecutableElement resynthesized,
ExecutableElement original, String desc) {
// We don't resynthesize local elements during link.
// So, we should not compare them.
@@ -154,18 +154,6 @@ class AstInferredTypeTest extends AbstractResynthesizeTest
@override
@failingTest
- void test_downwardsInferenceOnFunctionOfTUsingTheT() {
- super.test_downwardsInferenceOnFunctionOfTUsingTheT();
- }
-
- @override
- @failingTest
- void test_downwardsInferenceOnGenericFunctionExpressions() {
- super.test_downwardsInferenceOnGenericFunctionExpressions();
- }
-
- @override
- @failingTest
void test_genericMethods_inferJSBuiltin() {
super.test_genericMethods_inferJSBuiltin();
}
@@ -579,12 +567,6 @@ var v = new C().m(1, b: 'bbb', c: 2.0);
expect(unit.topLevelVariables[0].type.toString(), 'int');
}
- @override
- @failingTest
- void test_nullLiteralShouldNotInferAsBottom() {
- super.test_nullLiteralShouldNotInferAsBottom();
- }
-
LibraryElementImpl _checkSource(
SummaryResynthesizer resynthesizer, Source source) {
LibraryElementImpl resynthesized =
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698