MD User Manager: Supervised user checkbox is always displaying

chrome/browser/resources/md_user_manager/create_profile.js

Index: chrome/browser/resources/md_user_manager/create_profile.js
diff --git a/chrome/browser/resources/md_user_manager/create_profile.js b/chrome/browser/resources/md_user_manager/create_profile.js
index 63cfa78c672462a98f915630b6d70932dd14f853..7eceabfc71e3a0da60593fb0fcaa2cb9977ea272 100644
--- a/chrome/browser/resources/md_user_manager/create_profile.js
+++ b/chrome/browser/resources/md_user_manager/create_profile.js
@@ -132,7 +132,7 @@ Polymer({
 
   /**
    * Handles tap events from dynamically created links in warning/error messages
-   * pushed by the browser.
+   * pushed by the browser as well as the noSignedInUserMessage i18n string.

[tommycli, 2016/05/02 19:10:13]

Would this comment be more readable as?

Handles tap events from:
 - links within dynamic warning/error messages pushed from the browser
 - the 'noSignedInUserMessage' i18n string

[Moe, 2016/05/02 20:34:56]

Done.

    * @param {!Event} event
    * @private
    */
@@ -142,6 +142,9 @@ Polymer({
     if (element.id == 'supervised-user-import-existing') {
       this.onImportUserTap_(event);
       event.preventDefault();
+    } else if (element.id == 'sign-in-to-chrome') {
+      this.browserProxy_.openUrlInLastActiveProfileBrowser(element.href);
+      event.preventDefault();

[tommycli, 2016/05/02 19:10:13]

You could move this line outside the if blocks

[Moe, 2016/05/02 20:34:57]

This handler handles all tap events on the page. We only want to call
preventDefault when the tap is coming from one of these elements. I can wrap the
if-elseif chain inside another if condition that checks if the source of the
event is a link and move this line to the outer if condition. But I don't think
that's easier to read.

[tommycli, 2016/05/02 21:57:49]

You are correct. My mistake :)

     }
     // TODO(mahmadi): handle tap event on '#reauth' to re-auth the custodian.
   },