MD User Manager: Supervised user checkbox is always displaying

chrome/browser/resources/md_user_manager/create_profile.html

Index: chrome/browser/resources/md_user_manager/create_profile.html
diff --git a/chrome/browser/resources/md_user_manager/create_profile.html b/chrome/browser/resources/md_user_manager/create_profile.html
index 19c76b97312d74503a51fdce3a31bf7beddeec11..e4baaf74f16c2a30a6217bd64c6d9c5d6681cac5 100644
--- a/chrome/browser/resources/md_user_manager/create_profile.html
+++ b/chrome/browser/resources/md_user_manager/create_profile.html
@@ -75,26 +75,6 @@
         width: 300px;
       }
 
-      paper-dropdown-menu {
-        margin-top: 12px;
-        width: 200px;
-      }
-
-      paper-menu {
-        --paper-menu: {
-          color: inherit;
-          padding: 0;
-        };
-        --paper-menu-selected-item: {
-          font-weight: normal;
-        }
-      }
-
-      paper-menu paper-item {
-        font-size: inherit;
-        min-height: 40px;
-      }
-
       #icons #wrapper {
         display: flex;
         flex-wrap: wrap;
@@ -122,23 +102,48 @@
       }
 
       #supervised-user-container paper-checkbox {
+        --primary-text-color: var(--paper-grey-800);
         --paper-checkbox-label-spacing: 16px;
         --paper-checkbox-size: 20px;
       }
 
-      #supervised-user-container #learn-more-accounts {
+      #supervised-user-container #learn-more,

[tommycli, 2016/05/02 19:10:12]

instead of this, can you use

-webkit-padding-start on #supervised-user-container? Then you wouldn't need to
apply this rule to both ids

[Moe, 2016/05/02 20:34:56]

Done.

+      #supervised-user-container #custodians {
         -webkit-margin-start: 36px;
       }
 
       #supervised-user-container #learn-more {
-        display: block;
         line-height: 20px;
       }
 
+      #supervised-user-container paper-dropdown-menu {

[tommycli, 2016/05/02 19:10:13]

What was the purpose of moving these rules to the more specific selector? Just
to be more specific? (Not saying to reverse this change, I'm just curious)

[Moe, 2016/05/02 20:34:56]

It's more for readability and personal preference. When glancing at these it,
you'd immediately know where they appear in the html rather having to search for
them and go back and forth between html and css.

+        margin-top: 4px;
+        width: 200px;
+      }
+
+      #supervised-user-container paper-menu {
+        --paper-menu: {
+          color: inherit;
+          padding: 0;
+        };
+        --paper-menu-selected-item: {
+          font-weight: normal;
+        };
+      }
+
+      #supervised-user-container paper-menu paper-item {
+        font-size: inherit;
+        min-height: 40px;
+      }
+
       #supervised-user-container #import-user {
         -webkit-margin-start: 16px;
       }
 
+      #supervised-user-container #sign-in-howto-message {
+        margin-top: 12px;
+      }
+
       #actions {
         bottom: 16px;
         display: flex;
@@ -199,16 +204,16 @@
         </template>
         </div>
       </div>
-      <template is="dom-if" if="[[isSignedIn_(signedInUsers_)]]">
-        <div id="supervised-user-container">
-          <paper-checkbox checked="{{isSupervised_}}">
-            [[i18n('manageProfilesSupervisedSignedInLabel')]]
-          </paper-checkbox>
-          <div id="learn-more-accounts">
-            <a id="learn-more" is="action-link" on-tap="onLearnMoreTap_">
-              [[i18n('learnMore')]]
-            </a>
-            <template is="dom-if" if="[[isSupervised_]]">
+      <div id="supervised-user-container">
+        <paper-checkbox checked="{{isSupervised_}}">
+          [[i18n('manageProfilesSupervisedSignedInLabel')]]
+        </paper-checkbox>
+        <a id="learn-more" is="action-link" on-tap="onLearnMoreTap_">
+          [[i18n('learnMore')]]
+        </a>
+        <div id="custodians">

[tommycli, 2016/05/02 19:10:13]

If you can use -webkit-padding-start, you can get rid of this div

[Moe, 2016/05/02 20:34:56]

Done. However, removing this this would require adding another div around <a> so
the dropdown would go to the next line.

+          <template is="dom-if" if="[[isSupervised_]]">
+            <template is="dom-if" if="[[isSignedIn_(signedInUsers_)]]">
               <paper-dropdown-menu no-label-float>
                 <paper-menu class="dropdown-content"
                     selected="{{signedInUserIndex_}}"
@@ -229,9 +234,13 @@
                 [[i18n('importExistingSupervisedUserLink')]]
               </a>
             </template>
-          </div>
+            <div id="sign-in-howto-message"
+                hidden="[[isSignedIn_(signedInUsers_)]]"
+                inner-h-t-m-l="[[i18n('noSignedInUserMessage')]]">
+            </div>
+          </template>
         </div>
-      </template>
+      </div>
       <div id="actions">
         <paper-spinner active="[[createInProgress_]]"></paper-spinner>
         <paper-button id="cancel" on-tap="onCancelTap_" i18n-content="cancel">