Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1939733002: Revert of Web Animations: Expose timeline attributes on Animation object (experimental only) (Closed)

Created:
4 years, 7 months ago by dvadym
Modified:
4 years, 7 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Web Animations: Expose timeline attributes on Animation object (experimental only) (patchset #1 id:1 of https://codereview.chromium.org/1942683002/ ) Reason for revert: It breaks imported/web-platform-tests/web-animations/animation/playbackRate.html test on Windows https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg) and Linux webkit bots. For example https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/6983 Original issue's description: > Web Animations: Expose timeline attributes on Animation object (experimental only) > > Simply exposing this attribute lets us pass a few more web-platform-tests. > This brings us closer to the spec IDL for Animation: > http://w3c.github.io/web-animations/#dom-animation-timeline > > BUG=600248 > > Committed: https://crrev.com/a5e6866bfac27205bf03797613978df3320a6930 > Cr-Commit-Position: refs/heads/master@{#390900} TBR=suzyh@chromium.org,alancutter@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600248 Committed: https://crrev.com/cd84e041ed652812158b3f6fd6c98ae9fb083417 Cr-Commit-Position: refs/heads/master@{#390927}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
dvadym
Created Revert of Web Animations: Expose timeline attributes on Animation object (experimental only)
4 years, 7 months ago (2016-05-02 12:47:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939733002/1
4 years, 7 months ago (2016-05-02 12:47:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 12:47:56 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 12:49:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd84e041ed652812158b3f6fd6c98ae9fb083417
Cr-Commit-Position: refs/heads/master@{#390927}

Powered by Google App Engine
This is Rietveld 408576698