Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1939283002: cc: Fix sublayer scale bug in hit testing (Closed)

Created:
4 years, 7 months ago by jaydasika
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

cc: Fix sublayer scale bug in hit testing In hit testing, we should use the render surface screen space transform (which doesn't have sublayer scale) instead of the screen_space_transform stored on the transform node (which has the sublayer scale baked in) as the clips stored in clip tree already account for the scale. BUG=604731 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1917043002 Cr-Commit-Position: refs/heads/master@{#389873} (cherry picked from commit 0da498c027ed0b0d1c4596892c7666afaa5a98af) Committed: https://chromium.googlesource.com/chromium/src/+/97c769d0257b107238ab72175c74da80749d4778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -3 lines) Patch
M cc/trees/layer_tree_impl.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jaydasika
4 years, 7 months ago (2016-05-02 20:55:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
97c769d0257b107238ab72175c74da80749d4778.

Powered by Google App Engine
This is Rietveld 408576698