Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: content/child/v8_value_converter_impl.h

Issue 1939233002: Properly detect cycles in V8ValueConverter, current impl is too strict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments from asargent@ Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/v8_value_converter_impl.h
diff --git a/content/child/v8_value_converter_impl.h b/content/child/v8_value_converter_impl.h
index 5ad3297142b3367dbe08150d45aa28cb6056e32c..fd23c47a7e28b358ddac6e52b73646f40c6a6ac1 100644
--- a/content/child/v8_value_converter_impl.h
+++ b/content/child/v8_value_converter_impl.h
@@ -41,6 +41,7 @@ class CONTENT_EXPORT V8ValueConverterImpl : public V8ValueConverter {
friend class ScopedAvoidIdentityHashForTesting;
class FromV8ValueState;
+ class ScopedUniquenessGuard;
v8::Local<v8::Value> ToV8ValueImpl(v8::Isolate* isolate,
v8::Local<v8::Object> creation_context,

Powered by Google App Engine
This is Rietveld 408576698