Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: content/child/v8_value_converter_impl.h

Issue 1939233002: Properly detect cycles in V8ValueConverter, current impl is too strict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments from asargent@ Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_CHILD_V8_VALUE_CONVERTER_IMPL_H_ 5 #ifndef CONTENT_CHILD_V8_VALUE_CONVERTER_IMPL_H_
6 #define CONTENT_CHILD_V8_VALUE_CONVERTER_IMPL_H_ 6 #define CONTENT_CHILD_V8_VALUE_CONVERTER_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 23 matching lines...) Expand all
34 v8::Local<v8::Value> ToV8Value( 34 v8::Local<v8::Value> ToV8Value(
35 const base::Value* value, 35 const base::Value* value,
36 v8::Local<v8::Context> context) const override; 36 v8::Local<v8::Context> context) const override;
37 base::Value* FromV8Value(v8::Local<v8::Value> value, 37 base::Value* FromV8Value(v8::Local<v8::Value> value,
38 v8::Local<v8::Context> context) const override; 38 v8::Local<v8::Context> context) const override;
39 39
40 private: 40 private:
41 friend class ScopedAvoidIdentityHashForTesting; 41 friend class ScopedAvoidIdentityHashForTesting;
42 42
43 class FromV8ValueState; 43 class FromV8ValueState;
44 class ScopedUniquenessGuard;
44 45
45 v8::Local<v8::Value> ToV8ValueImpl(v8::Isolate* isolate, 46 v8::Local<v8::Value> ToV8ValueImpl(v8::Isolate* isolate,
46 v8::Local<v8::Object> creation_context, 47 v8::Local<v8::Object> creation_context,
47 const base::Value* value) const; 48 const base::Value* value) const;
48 v8::Local<v8::Value> ToV8Array(v8::Isolate* isolate, 49 v8::Local<v8::Value> ToV8Array(v8::Isolate* isolate,
49 v8::Local<v8::Object> creation_context, 50 v8::Local<v8::Object> creation_context,
50 const base::ListValue* list) const; 51 const base::ListValue* list) const;
51 v8::Local<v8::Value> ToV8Object( 52 v8::Local<v8::Value> ToV8Object(
52 v8::Isolate* isolate, 53 v8::Isolate* isolate,
53 v8::Local<v8::Object> creation_context, 54 v8::Local<v8::Object> creation_context,
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 90
90 // Strategy object that changes the converter's behavior. 91 // Strategy object that changes the converter's behavior.
91 Strategy* strategy_; 92 Strategy* strategy_;
92 93
93 DISALLOW_COPY_AND_ASSIGN(V8ValueConverterImpl); 94 DISALLOW_COPY_AND_ASSIGN(V8ValueConverterImpl);
94 }; 95 };
95 96
96 } // namespace content 97 } // namespace content
97 98
98 #endif // CONTENT_CHILD_V8_VALUE_CONVERTER_IMPL_H_ 99 #endif // CONTENT_CHILD_V8_VALUE_CONVERTER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698