content/child/v8_value_converter_impl.h - Issue 1939233002: Properly detect cycles in V8ValueConverter, current impl is too strict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/v8_value_converter_impl.h

Issue 1939233002: Properly detect cycles in V8ValueConverter, current impl is too strict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from asargent@ Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc ('k') | content/child/v8_value_converter_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/v8_value_converter_impl.h

diff --git a/content/child/v8_value_converter_impl.h b/content/child/v8_value_converter_impl.h

index 5ad3297142b3367dbe08150d45aa28cb6056e32c..fd23c47a7e28b358ddac6e52b73646f40c6a6ac1 100644

--- a/content/child/v8_value_converter_impl.h

+++ b/content/child/v8_value_converter_impl.h

@@ -41,6 +41,7 @@ class CONTENT_EXPORT V8ValueConverterImpl : public V8ValueConverter {

friend class ScopedAvoidIdentityHashForTesting;

class FromV8ValueState;

+ class ScopedUniquenessGuard;

v8::Local<v8::Value> ToV8ValueImpl(v8::Isolate* isolate,

v8::Local<v8::Object> creation_context,