Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1939173002: Fix Scanner::PushBack for surrogate code points. (Closed)

Created:
4 years, 7 months ago by vogelheim
Modified:
4 years, 7 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Scanner::PushBack for surrogate code points. A wise man once said: If you want right result, compare right value. R=rossberg@chromium.org BUG= Committed: https://crrev.com/ec2cb20896eaeb222c90b1cb4a36faa3d9c3c25f Cr-Commit-Position: refs/heads/master@{#35967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/parsing/scanner.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vogelheim
I found this while working on crrev.com/1941843002. It's unrelated to that bug and I'm unaware ...
4 years, 7 months ago (2016-05-02 17:19:49 UTC) #1
rossberg
Ha ha, lgtm.
4 years, 7 months ago (2016-05-03 09:16:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1939173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1939173002/1
4 years, 7 months ago (2016-05-03 09:37:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 09:40:17 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 09:41:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec2cb20896eaeb222c90b1cb4a36faa3d9c3c25f
Cr-Commit-Position: refs/heads/master@{#35967}

Powered by Google App Engine
This is Rietveld 408576698